[PATCH] winemenubuilder: check for NULL allocation (Coverity)
Marcus Meissner
marcus at jet.franken.de
Tue Aug 11 03:04:55 CDT 2009
Hi,
Coverity sees buffer being NULL in one path (OOM),
so check for it too.
The callers check for NULL returns already.
Ciao, Marcus
---
programs/winemenubuilder/winemenubuilder.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c
index 15ce483..ba6fa64 100644
--- a/programs/winemenubuilder/winemenubuilder.c
+++ b/programs/winemenubuilder/winemenubuilder.c
@@ -724,6 +724,7 @@ static char* heap_printf(const char *format, ...)
HeapFree(GetProcessHeap(), 0, buffer);
}
va_end(args);
+ if (!buffer) return NULL;
ret = HeapReAlloc(GetProcessHeap(), 0, buffer, strlen(buffer) + 1 );
if (!ret) ret = buffer;
return ret;
--
1.5.6
More information about the wine-patches
mailing list