[PATCH] cryptnet: Added a potentially missing NULL ptr check (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Dec 1 03:26:48 CST 2009


Hi,

We check pRevPara for NULL earlier, so we should also check it here.

Ciao, Marcus
---
 dlls/cryptnet/cryptnet_main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/cryptnet/cryptnet_main.c b/dlls/cryptnet/cryptnet_main.c
index afae942..34bbc58 100644
--- a/dlls/cryptnet/cryptnet_main.c
+++ b/dlls/cryptnet/cryptnet_main.c
@@ -1616,7 +1616,8 @@ BOOL WINAPI CertDllVerifyRevocation(DWORD dwEncodingType, DWORD dwRevType,
                      NULL);
                     if (dwFlags & CERT_VERIFY_CACHE_ONLY_BASED_REVOCATION)
                         retrievalFlags |= CRYPT_CACHE_ONLY_RETRIEVAL;
-                    if (dwFlags & CERT_VERIFY_REV_ACCUMULATIVE_TIMEOUT_FLAG &&
+                    if ((dwFlags & CERT_VERIFY_REV_ACCUMULATIVE_TIMEOUT_FLAG) &&
+                     pRevPara &&
                      pRevPara->cbSize >= offsetof(CERT_REVOCATION_PARA,
                      dwUrlRetrievalTimeout) + sizeof(DWORD))
                     {
-- 
1.5.6



More information about the wine-patches mailing list