[PATCH 2/3] msi: Free the column info data when updating the table column info.

James Hawkins truiken at gmail.com
Mon Dec 7 21:55:21 CST 2009


I had to strdup name because most callers of msi_update_table_columns
send in colinfo->tablename as the name parameter, which is freed by
msi_free_colinfo.

Fixes many valgrind errors of the form:

X bytes in 1 blocks are definitely lost
    at  notify_alloc (heap.c:247)
    by  RtlAllocateHeap (heap.c:1697)
    by  msi_alloc (msipriv.h:1078)
    by  strdupW (msipriv.h:1134)
    by  msi_create_table (table.c:664)
    by  CREATE_execute (create.c:72)
    by  MSI_ViewExecute (msiquery.c:462)
    by  MsiViewExecute (msiquery.c:488)
---
 dlls/msi/table.c |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-msi-Free-the-column-info-data-when-updating-the-tabl.patch
Type: text/x-patch
Size: 1401 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091207/56c911d5/attachment-0001.bin>


More information about the wine-patches mailing list