[PATCH] rpcrt4: exit on unknown confirmance type (Coverity)

Marcus Meissner meissner at suse.de
Tue Dec 15 04:44:37 CST 2009


Hi,

Difficult to handle as the function has no concept of error return,
but I dont want to rewrite it without knowing it better.

So make the badness more visible and exit the function.

Ciao, Marcus
---
 dlls/rpcrt4/ndr_marshall.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/rpcrt4/ndr_marshall.c b/dlls/rpcrt4/ndr_marshall.c
index 4c9f625..3b10af4 100644
--- a/dlls/rpcrt4/ndr_marshall.c
+++ b/dlls/rpcrt4/ndr_marshall.c
@@ -551,7 +551,8 @@ PFORMAT_STRING ComputeConformanceOrVariance(
     }
     break;
   default:
-    FIXME("unknown conformance type %x\n", pFormat[0] & 0xf0);
+    FIXME("unknown conformance type %x, expect crash.\n", pFormat[0] & 0xf0);
+    goto finish_conf;
   }
 
   switch (pFormat[1]) {
-- 
1.6.4.2



More information about the wine-patches mailing list