[PATCH 1/7] msi: Keep track of the current view in the sql parser. This allows us to free said view in the case of a syntax error. This also allows us to get rid of a few places where we tried to clean up the view ourselves in the parsing code.

James Hawkins truiken at gmail.com
Tue Dec 15 20:18:31 CST 2009


Fixes a valgrind error of the form:

50 bytes in 1 blocks are definitely lost
    at  notify_alloc (heap.c:247)
    by  RtlAllocateHeap (heap.c:1697)
    by  msi_alloc_zero (msipriv.h:1085)
    by  TABLE_CreateView (table.c:2376)
    by  sql_parse (sql.y:486)
    by  MSI_ParseSQL (sql.y:960)
    by  MSI_DatabaseOpenViewW (msiquery.c:137)
    by  MsiDatabaseOpenViewW (msiquery.c:279)
---
 dlls/msi/sql.y |   83 +++++++++++++++++++++++++++++++++++---------------------
 1 files changed, 52 insertions(+), 31 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-msi-Keep-track-of-the-current-view-in-the-sql-parser.patch
Type: text/x-patch
Size: 6938 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091215/cfc1513d/attachment-0001.bin>


More information about the wine-patches mailing list