[gdiplus/tests] Fix a test failure on XP/W2K3

Paul Vriens paul.vriens.wine at gmail.com
Thu Dec 17 04:11:33 CST 2009


Hi,

Initializes the struct a bit more. Credit to Vincent for finding the reason:

 > Somehow the memory containing the image data where that pixel was set
 > to 0xffffffff is now being used for LogPal (which, for some
 > unfathomable reason, is dynamically allocated). Now, we don't fully
 > initialize LogPal before we pass it to CreatePalette (also for some
 > unfathomable reason) so LogPal->palNumEntries happens to be 0xffff
 > now, which is a fairly big number. Maybe CreatePalette doesn't like
 > numbers that big.
 >
 > Of course, this isn't a problem for Wine, because Wine's gdiplus
 > doesn't keep it's image data in heap-allocated memory (yet).
 >
 > I'd try setting the palNumEntries to 0 or 1.

0 didn't work btw.

Changelog
   Fix a test failure on XP/W2K3

-- 
Cheers,

Paul.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Fix-a-test-failure-on-XP-W2K3.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091217/57d9ff06/attachment.asc>


More information about the wine-patches mailing list