[PATCH 2/2] mciavi: Do not stub unsupported recording or editing functions.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Fri Dec 18 04:27:33 CST 2009


Hi,

I'm somewhat sorry to remove somebody else's stub code.  I'm doing so because
 1. Native w2k does not support editing/recording either (on stock HW)
    and returns MCIERR_UNSUPPORTED_FUNCTION, not 0 (nor does it call mci_stop).
 2. This is reflected by the MCI GetDevCaps/capability command (returns FALSE).
 3. Managing MCIERR_UNSUPPORTED_FUNCTION in a central place makes further
    patches of mine easier, e.g. correct support of the MCI_TEST flag.
 4. I don't believe Wine will implement recording and editing anytime soon
    (why should it, since w2k does not feature it either), so
    we may as well get rid of 10KB of (incorrect) stub code.

BTW, how would we write tests for something that even MS does not implement?  E.g. we have code for MIDI recording (that I don't plan to drop) but where is PC HW running MS-W* that supports it?

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-mciavi-Do-not-stub-unsupported-recording-or-editing.patch
Type: application/octet-stream
Size: 15555 bytes
Desc: 0003-mciavi-Do-not-stub-unsupported-recording-or-editing.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091218/641be3b3/attachment-0001.obj>


More information about the wine-patches mailing list