dlls/wnaspi32/winaspi16.c on non-Linux

Gerald Pfeifer gerald at pfeifer.com
Wed Feb 4 04:47:09 CST 2009


I noticed that the body of ASPI_SendASPICommand itself is also
guarded by #ifdef linux/#endif, short of the return function which
return SS_INVALID_SRB in that case.

That strikes me as better than just returning 0 here when indeed
we do not actually succeed the call on non-Linux platforms.

(If you disagree, the alternate patch would be guarding all of
ASPI_SendASPICommand by #ifdef linux, not just the main body.)

Thoughts?

Gerald

ChangeLog:
Invoke ASPI_SendASPICommand() on non-Linux platforms, too.

Index: dlls/wnaspi32/winaspi16.c
===================================================================
RCS file: /home/wine/wine/dlls/wnaspi32/winaspi16.c,v
retrieving revision 1.8
diff -u -3 -p -r1.8 winaspi16.c
--- dlls/wnaspi32/winaspi16.c	3 Feb 2009 15:14:00 -0000	1.8
+++ dlls/wnaspi32/winaspi16.c	4 Feb 2009 00:37:38 -0000
@@ -440,11 +440,7 @@ adapter name */
  */
 WORD WINAPI SendASPICommand16(SEGPTR segptr_srb)
 {
-#ifdef linux
     return ASPI_SendASPICommand(segptr_srb, ASPI_WIN16);
-#else
-    return 0;
-#endif
 }
 
 



More information about the wine-patches mailing list