[PATCH] Implement IHTMLStyle get/put minHeight
Alistair Leslie-Hughes
leslie_alistair at hotmail.com
Mon Feb 9 03:36:16 CST 2009
---
dlls/mshtml/htmlstyle.c | 5 ++++-
dlls/mshtml/htmlstyle.h | 1 +
dlls/mshtml/htmlstyle3.c | 28 ++++++++++++++++++++++++----
dlls/mshtml/tests/dom.c | 34 ++++++++++++++++++++++++++++++++++
4 files changed, 63 insertions(+), 5 deletions(-)
diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c
index 5490fcc..48f6516 100644
--- a/dlls/mshtml/htmlstyle.c
+++ b/dlls/mshtml/htmlstyle.c
@@ -83,6 +83,8 @@ static const WCHAR attrMarginLeft[] =
{'m','a','r','g','i','n','-','l','e','f','t',0};
static const WCHAR attrMarginRight[] =
{'m','a','r','g','i','n','-','r','i','g','h','t',0};
+static const WCHAR attrMinHeight[] =
+ {'m','i','n','-','h','e','i','g','h','t',0};
static const WCHAR attrOverflow[] =
{'o','v','e','r','f','l','o','w',0};
static const WCHAR attrPaddingLeft[] =
@@ -132,6 +134,7 @@ static const struct{
{attrMargin, DISPID_IHTMLSTYLE_MARGIN},
{attrMarginLeft, DISPID_IHTMLSTYLE_MARGINLEFT},
{attrMarginRight, DISPID_IHTMLSTYLE_MARGINRIGHT},
+ {attrMinHeight, DISPID_IHTMLSTYLE4_MINHEIGHT},
{attrOverflow, DISPID_IHTMLSTYLE_OVERFLOW},
{attrPaddingLeft, DISPID_IHTMLSTYLE_PADDINGLEFT},
{attrPosition, DISPID_IHTMLSTYLE2_POSITION},
@@ -260,7 +263,7 @@ static HRESULT set_nsstyle_attr_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_
return S_OK;
}
-static inline HRESULT set_style_attr(HTMLStyle *This, styleid_t sid, LPCWSTR value, DWORD flags)
+HRESULT set_style_attr(HTMLStyle *This, styleid_t sid, LPCWSTR value, DWORD flags)
{
return set_nsstyle_attr(This->nsstyle, sid, value, flags);
}
diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h
index a9ff535..13db170 100644
--- a/dlls/mshtml/htmlstyle.h
+++ b/dlls/mshtml/htmlstyle.h
@@ -59,6 +59,7 @@ typedef enum {
STYLEID_MARGIN,
STYLEID_MARGIN_LEFT,
STYLEID_MARGIN_RIGHT,
+ STYLEID_MIN_HEIGHT,
STYLEID_OVERFLOW,
STYLEID_PADDING_LEFT,
STYLEID_POSITION,
diff --git a/dlls/mshtml/htmlstyle3.c b/dlls/mshtml/htmlstyle3.c
index f5ed8b5..ee00a1a 100644
--- a/dlls/mshtml/htmlstyle3.c
+++ b/dlls/mshtml/htmlstyle3.c
@@ -409,15 +409,35 @@ static HRESULT WINAPI HTMLStyle4_get_textOverflow(IHTMLStyle4 *iface, BSTR *p)
static HRESULT WINAPI HTMLStyle4_put_minHeight(IHTMLStyle4 *iface, VARIANT v)
{
HTMLStyle *This = HTMLSTYLE4_THIS(iface);
- FIXME("(%p)->(%s)\n", This, debugstr_variant(&v));
- return E_NOTIMPL;
+
+ TRACE("(%p)->(%s)\n", This, debugstr_variant(&v));
+
+ switch(V_VT(&v)) {
+ case VT_BSTR:
+ return set_nsstyle_attr(This->nsstyle, STYLEID_MIN_HEIGHT, V_BSTR(&v), 0);
+ case VT_I4: {
+ WCHAR value[14];
+ static const WCHAR format[] = {'%','d',0};
+
+ wsprintfW(value, format, V_I4(&v));
+ return set_nsstyle_attr(This->nsstyle, STYLEID_MIN_HEIGHT, value, 0);
+ }
+ default:
+ FIXME("unimplemented vt %d\n", V_VT(&v));
+ return E_NOTIMPL;
+ }
+
+ return S_OK;
}
static HRESULT WINAPI HTMLStyle4_get_minHeight(IHTMLStyle4 *iface, VARIANT *p)
{
HTMLStyle *This = HTMLSTYLE4_THIS(iface);
- FIXME("(%p)->(%p)\n", This, p);
- return E_NOTIMPL;
+
+ TRACE("(%p)->(%p)\n", This, p);
+
+ V_VT(p) = VT_BSTR;
+ return get_nsstyle_attr(This->nsstyle, STYLEID_MIN_HEIGHT, &V_BSTR(p));
}
static const IHTMLStyle4Vtbl HTMLStyle4Vtbl = {
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index bcb14ef..12db12a 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -2403,9 +2403,35 @@ static void test_style2(IHTMLStyle2 *style2)
SysFreeString(str);
}
+static void test_style4(IHTMLStyle4 *style4)
+{
+ HRESULT hres;
+ VARIANT v;
+ VARIANT vdefault;
+
+ hres = IHTMLStyle4_get_minHeight(style4, &vdefault);
+ ok(hres == S_OK, "get_minHeight failed: %08x\n", hres);
+
+ V_VT(&v) = VT_BSTR;
+ V_BSTR(&v) = a2bstr("10px");
+ hres = IHTMLStyle4_put_minHeight(style4, v);
+ ok(hres == S_OK, "put_minHeight failed: %08x\n", hres);
+ VariantClear(&v);
+
+ hres = IHTMLStyle4_get_minHeight(style4, &v);
+ ok(hres == S_OK, "get_minHeight failed: %08x\n", hres);
+ ok(V_VT(&v) == VT_BSTR, "V_VT(v) = %d\n", V_VT(&v));
+ ok( !strcmp_wa(V_BSTR(&v), "10px"), "expect 10px got (%s)\n", dbgstr_w(V_BSTR(&v)));
+
+ hres = IHTMLStyle4_put_minHeight(style4, vdefault);
+ ok(hres == S_OK, "put_minHeight failed: %08x\n", hres);
+ VariantClear(&vdefault);
+}
+
static void test_default_style(IHTMLStyle *style)
{
IHTMLStyle2 *style2;
+ IHTMLStyle4 *style4;
VARIANT_BOOL b;
VARIANT v;
BSTR str;
@@ -3034,6 +3060,14 @@ static void test_default_style(IHTMLStyle *style)
test_style2(style2);
IHTMLStyle2_Release(style2);
}
+
+ hres = IHTMLStyle_QueryInterface(style, &IID_IHTMLStyle4, (void**)&style4);
+ ok(hres == S_OK, "Could not get IHTMLStyle4 iface: %08x\n", hres);
+ if(SUCCEEDED(hres)) {
+ test_style4(style4);
+ IHTMLStyle4_Release(style4);
+ }
+
}
static void test_default_selection(IHTMLDocument2 *doc)
--
1.5.4.3
--------------040803010307090809000202--
More information about the wine-patches
mailing list