[2/2] cmd: Reserve a place in buffer for NULL terminator

Nikolay Sivov bunglehead at gmail.com
Tue Feb 17 13:55:11 CST 2009


When filesize is greater or equal 512 bytes null terminator is placed outside a buffer
at least once.

Changelog:
    - Reserve a place in buffer for NULL terminator

>From 46f454f23a4f459a0d4acfb65f640476a3dc98bf Mon Sep 17 00:00:00 2001
From: Nikolay Sivov <bunglehead at gmail.com>
Date: Tue, 17 Feb 2009 22:45:21 +0300
Subject: Reserve a place in buffer for NULL terminator

---
 programs/cmd/builtins.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index 6679b86..bcdf840 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -2290,7 +2290,7 @@ void WCMD_type (WCHAR *command) {
         static const WCHAR fmt[] = {'\n','%','s','\n','\n','\0'};
         WCMD_output(fmt, thisArg);
       }
-      while (WCMD_ReadFile (h, buffer, sizeof(buffer)/sizeof(WCHAR), &count, NULL)) {
+      while (WCMD_ReadFile (h, buffer, sizeof(buffer)/sizeof(WCHAR) - 1, &count, NULL)) {
         if (count == 0) break;	/* ReadFile reports success on EOF! */
         buffer[count] = 0;
         WCMD_output_asis (buffer);
-- 
1.5.6.3





More information about the wine-patches mailing list