[try2] gdiplus/tests: Dynamically load gdiplus.dll.

Paul Vriens paul.vriens.wine at gmail.com
Mon Feb 23 06:15:04 CST 2009


Nicolas Le Cam wrote:
> 2009/2/23 Francois Gouget <fgouget at free.fr>:
>> On Sun, 22 Feb 2009, Nicolas Le Cam wrote:
>>
>>> This avoid a messagebox in regression tests on systems that don't have
>>> GdiPlus.
>>
>> This seems wrong because winetest.exe is already supposed to check for
>> missing dlls. If I remember correctly this was done explicitely so that
>> individual tests would not have to dynamically link everywhere.
>>
>> Also I tested on a platform that does not have gdiplus, and I did not
>> get a message box. In fact, on that platform, winetest did not extract
>> gdiplus_test.exe, which also seems very wrong to me.
>>
>> So I think that if there's any issue, it's on the winetest.exe side.
>>
>> --
>> Francois Gouget <fgouget at free.fr>              http://fgouget.free.fr/
>>            "Lotto: A tax on people who are bad at math." -- unknown
>>          "Windows: Microsoft's tax on computer illiterates." -- WE7U
>>
>>
>>
> 
> Thanks,
> 
> On my w2k pro when I launch the winetest obtained from
> test.winehq.org, I get a MessageBox saying gdiplus is missing, and
> there's already some tests that load dlls dynamically (advpack,
> cryptui, fusion) so thought it was the right way.
> 
> I will have a look on the winetest side.
> 
> Nicolas Le Cam
> 
> 
> 
The reason you see this is because next to a normal LoadLibrary we also use the 
.NET variant. On some boxes gdiplus.dll cannot be found through LoadLibrary but 
will trough LoadLibraryShim. As winetest now thinks the library is there it will 
try to launch "gdiplus_test.exe --list" and that of course fails.

Not sure how to approach this.

-- 
Cheers,

Paul.



More information about the wine-patches mailing list