makedep: let umask decide mode for Makefiles

[Paul Bryan Roberts]

The code as it stands creates makefiles with a mode of 600.  This may be 
benign on most (e.g. personal workstation) installations but not all. 

An example is where the wine git repository is located on an NFS 
volume.  Here security settings may mean that root:root is treated as 
nobody:nogroup.  Installation from the repository is not possible as 
root (whether via su or sudo) cannot even read the makefiles.

This behaviour is particularly confusing when using 
wine/tools/wineinstall as, in certain circumstances, this script will 
run make depend silently.  The 'user' is left with the impression that 
some capricious software has mischievously changed all the makefiles 
back to read-only.

The patch uses a create mode of 666, which under umask control, should 
result in makefiles the same mode as any other Wine source file.

With this patch installation from an NFS volume now works without 
manually changing makefile modes and a single compiler error no longer 
results in makefiles turning read-only.  I don't think a Wine 
conformance test is possible.  The patch's effect on makefile mode has 
been essayed with a variety of umask settings under Ubuntu Hardy.

I don't see how this patch could stop Scott Richie making the next 
Ubuntu development release but should he think otherwise I'd be 
interested in feedback.  Likewise if anyone can remember the good reason 
for using a mode of 600 in the first place.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-makedep-let-umask-decide-mode-for-Makefiles.txt
Url: http://www.winehq.org/pipermail/wine-patches/attachments/20090224/56cf99cb/attachment.txt