[PATCH] wininet: added one missing buffersize check in URLCache_CopyEntry (Coverity)
Marcus Meissner
marcus at jet.franken.de
Fri Jan 30 15:53:28 CST 2009
Hi,
CID 831, indirectly spotted by Coverity, one missing
check for (*lpdwBufferSize >= dwRequiredSize) added.
Ciao, Marcus
---
dlls/wininet/urlcache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c
index c22883d..0cab90f 100644
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -1006,7 +1006,7 @@ static DWORD URLCache_CopyEntry(
ZeroMemory((LPBYTE)lpCacheEntryInfo + dwRequiredSize, 4 - (dwRequiredSize % 4));
dwRequiredSize = DWORD_ALIGN(dwRequiredSize);
- if (pUrlEntry->dwOffsetLocalName)
+ if (pUrlEntry->dwOffsetLocalName && (*lpdwBufferSize >= dwRequiredSize))
{
LONG nLocalFilePathSize;
LPSTR lpszLocalFileName;
--
1.5.6
More information about the wine-patches
mailing list