[PATCH] itss: move buffer initialization a bit up (Coverity)

Marcus Meissner marcus at jet.franken.de
Sat Jan 31 16:50:30 CST 2009


CID 61, the buffers might have been accessed earlier.
So take care that they are allocated before we start
reading stuff.

Might not really be a problem here though.

Ciao, Marcus
---
 dlls/itss/chm_lib.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/itss/chm_lib.c b/dlls/itss/chm_lib.c
index 6b80ef2..e0fceb3 100644
--- a/dlls/itss/chm_lib.c
+++ b/dlls/itss/chm_lib.c
@@ -759,6 +759,10 @@ struct chmFile *chm_openW(const WCHAR *filename)
     if (newHandle->index_root == -1)
         newHandle->index_root = newHandle->index_head;
 
+    /* initialize cache */
+    chm_set_param(newHandle, CHM_PARAM_MAX_BLOCKS_CACHED,
+                  CHM_MAX_BLOCKS_CACHED);
+
     /* By default, compression is enabled. */
     newHandle->compression_enabled = 1;
 
@@ -822,10 +826,6 @@ struct chmFile *chm_openW(const WCHAR *filename)
 #endif
     }
 
-    /* initialize cache */
-    chm_set_param(newHandle, CHM_PARAM_MAX_BLOCKS_CACHED,
-                  CHM_MAX_BLOCKS_CACHED);
-
     return newHandle;
 }
 
-- 
1.5.6



More information about the wine-patches mailing list