kernel32: fix a valgrind warning

Austin English austinenglish at gmail.com
Thu Jul 9 14:07:33 CDT 2009


Patch by John Reiser <jreiser at BitWagon.com>. Sent last year right
before 1.0. See bug 14359.

-- 
-Austin
-------------- next part --------------
From d9d36a20fc2d6062c3e089fef4651e8f3b6a22b9 Mon Sep 17 00:00:00 2001
From: John Reiser <jreiser at BitWagon.com>
Date: Thu, 9 Jul 2009 13:44:42 -0500
Subject: [PATCH] kernel32: fix a valgrind warning

---
 dlls/kernel32/process.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index 4e74782..65e938a 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -1175,6 +1175,7 @@ static char **build_argv( const WCHAR *cmdlineW, int reserved )
         HeapFree( GetProcessHeap(), 0, cmdline );
         return NULL;
     }
+    memset(argv, 0, reserved*sizeof(*argv));
 
     arg = d = s = (char *)(argv + argc);
     memcpy( d, cmdline, len );
@@ -1227,7 +1228,7 @@ static char **build_argv( const WCHAR *cmdlineW, int reserved )
         *d='\0';
         argv[argc++]=arg;
     }
-    argv[argc]=NULL;
+    argv[argc++]=NULL;
 
     HeapFree( GetProcessHeap(), 0, cmdline );
     return argv;
-- 
1.5.4.3


More information about the wine-patches mailing list