[2/4] wininet: Don't leak the proxy username and password in WININET_SetProxyAuthorization.

Hans Leidekker hans at codeweavers.com
Thu Jul 23 05:04:59 CDT 2009


diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
index 4a4df92..2235d85 100644
--- a/dlls/wininet/dialogs.c
+++ b/dlls/wininet/dialogs.c
@@ -231,12 +231,14 @@ static BOOL WININET_SetProxyAuthorization( HINTERNET hRequest,
     if( !p )
         goto done;
 
+    HeapFree(GetProcessHeap(), 0, hIC->lpszProxyUsername);
     hIC->lpszProxyUsername = p;
 
     p = heap_strdupW(password);
     if( !p )
         goto done;
 
+    HeapFree(GetProcessHeap(), 0, hIC->lpszProxyPassword);
     hIC->lpszProxyPassword = p;
 
     ret = TRUE;



More information about the wine-patches mailing list