dlls/user32: Fix condition to account for HDN_ITEMCHANGINGA > HDN_ENDDRAG

Gerald Pfeifer gerald at pfeifer.com
Sun Jun 7 04:20:54 CDT 2009


commctrl.h has 

  #define HDN_ITEMCHANGINGA       (HDN_FIRST-0)
  #define HDN_ENDDRAG             (HDN_FIRST-11)

which means that the following condition always evaluates to false

  (pnmh->code >= HDN_ITEMCHANGINGA) && (pnmh->code <= HDN_ENDDRAG)

Assuming that indeed we want to check for the interval between those
two constants, this patches fixes it.

Gerald

ChangeLog:
Fix logic condition in SPY_DumpStructure().

diff --git a/dlls/user32/spy.c b/dlls/user32/spy.c
index 8cd926b..c2bd60b 100644
--- a/dlls/user32/spy.c
+++ b/dlls/user32/spy.c
@@ -2489,7 +2489,8 @@ static void SPY_DumpStructure(const SPY_INSTANCE *sp_e, BOOL enter)
                         SetLastError(save_error);
                         if (strcmpW(TOOLBARCLASSNAMEW, from_class) == 0)
                             dumplen = sizeof(NMTBCUSTOMDRAW)-sizeof(NMHDR);
-                    } else if ((pnmh->code >= HDN_ITEMCHANGINGA) && (pnmh->code <= HDN_ENDDRAG)) {
+                    } else if ( pnmh->code >= HDN_ENDDRAG
+                                && pnmh->code <= HDN_ITEMCHANGINGA ) {
                         dumplen = sizeof(NMHEADERA)-sizeof(NMHDR);
                     }
                     if (dumplen > 0) {



More information about the wine-patches mailing list