iphlpapi/tests: skip over unimplemented funtionality

Austin English austinenglish at gmail.com
Sun Mar 1 21:44:23 CST 2009


There's already one skip() in the file for some unimplemented stuff,
so basing these fixes on that (only skipping on ERROR_NOT_SUPPORTED).
If that's not what we should be doing (and just let it fail instead),
feel free to ignore. I asked on #winehackers but couldn't get a clear
answer as to what skip() should be used for...

-- 
-Austin
-------------- next part --------------
diff --git a/dlls/iphlpapi/tests/iphlpapi.c b/dlls/iphlpapi/tests/iphlpapi.c
index 23f85ec..7a86a72 100644
--- a/dlls/iphlpapi/tests/iphlpapi.c
+++ b/dlls/iphlpapi/tests/iphlpapi.c
@@ -201,6 +201,11 @@ static void testGetIfEntry(DWORD index)
      apiReturn);
     row.dwIndex = index;
     apiReturn = gGetIfEntry(&row);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetIfEntry is not supported\n");
+      return;
+    }
     ok(apiReturn == NO_ERROR, 
      "GetIfEntry returned %d, expected NO_ERROR\n", apiReturn);
   }
@@ -283,6 +288,11 @@ static void testGetIpForwardTable(void)
      "GetIpForwardTable(NULL, NULL, FALSE) returned %d, expected ERROR_INVALID_PARAMETER\n",
      apiReturn);
     apiReturn = gGetIpForwardTable(NULL, &dwSize, FALSE);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetIpForwardTable is not supported\n");
+      return;
+    }
     ok(apiReturn == ERROR_INSUFFICIENT_BUFFER,
      "GetIpForwardTable(NULL, &dwSize, FALSE) returned %d, expected ERROR_INSUFFICIENT_BUFFER\n",
      apiReturn);
@@ -290,6 +300,11 @@ static void testGetIpForwardTable(void)
       PMIB_IPFORWARDTABLE buf = HeapAlloc(GetProcessHeap(), 0, dwSize);
 
       apiReturn = gGetIpForwardTable(buf, &dwSize, FALSE);
+      if (apiReturn == ERROR_NOT_SUPPORTED)
+      {
+        skip("GetIpForwardTable is not supported\n");
+        return;
+      }
       ok(apiReturn == NO_ERROR,
        "GetIpForwardTable(buf, &dwSize, FALSE) returned %d, expected NO_ERROR\n",
        apiReturn);
@@ -313,6 +328,11 @@ static void testGetIpNetTable(void)
      "GetIpNetTable(NULL, NULL, FALSE) returned %d, expected ERROR_INVALID_PARAMETER\n",
      apiReturn);
     apiReturn = gGetIpNetTable(NULL, &dwSize, FALSE);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetIpNetTable is not supported\n");
+      return;
+    }
     ok(apiReturn == ERROR_NO_DATA || apiReturn == ERROR_INSUFFICIENT_BUFFER,
      "GetIpNetTable(NULL, &dwSize, FALSE) returned %d, expected ERROR_NO_DATA or ERROR_INSUFFICIENT_BUFFER\n",
      apiReturn);
@@ -322,6 +342,11 @@ static void testGetIpNetTable(void)
       PMIB_IPNETTABLE buf = HeapAlloc(GetProcessHeap(), 0, dwSize);
 
       apiReturn = gGetIpNetTable(buf, &dwSize, FALSE);
+      if (apiReturn == ERROR_NOT_SUPPORTED)
+      {
+        skip("GetIpNetTable is not supported\n");
+        return;
+      }
       ok(apiReturn == NO_ERROR ||
          apiReturn == ERROR_NO_DATA, /* empty ARP table's okay */
        "GetIpNetTable(buf, &dwSize, FALSE) returned %d, expected NO_ERROR\n",
@@ -373,6 +398,11 @@ static void testGetIpStatistics(void)
      "GetIpStatistics(NULL) returned %d, expected ERROR_INVALID_PARAMETER\n",
      apiReturn);
     apiReturn = gGetIpStatistics(&stats);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetIpStatistics is not supported\n");
+      return;
+    }
     ok(apiReturn == NO_ERROR,
       "GetIpStatistics returned %d, expected NO_ERROR\n", apiReturn);
   }
@@ -393,6 +423,11 @@ static void testGetTcpStatistics(void)
      "GetTcpStatistics(NULL) returned %d, expected ERROR_INVALID_PARAMETER\n",
      apiReturn);
     apiReturn = gGetTcpStatistics(&stats);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetTcpStatistics is not supported\n");
+      return;
+    }
     ok(apiReturn == NO_ERROR,
       "GetTcpStatistics returned %d, expected NO_ERROR\n", apiReturn);
   }
@@ -413,6 +448,11 @@ static void testGetUdpStatistics(void)
      "GetUdpStatistics(NULL) returned %d, expected ERROR_INVALID_PARAMETER\n",
      apiReturn);
     apiReturn = gGetUdpStatistics(&stats);
+    if (apiReturn == ERROR_NOT_SUPPORTED)
+    {
+      skip("GetUdpStatistics is not supported\n");
+      return;
+    }
     ok(apiReturn == NO_ERROR,
      "GetUdpStatistics returned %d, expected NO_ERROR\n", apiReturn);
   }


More information about the wine-patches mailing list