d3d8/tests: Avoid a crash, when CreateTexture failed

Detlef Riekenberg wine.dev at web.de
Thu Nov 5 18:33:37 CST 2009


http://source.winehq.org/git/wine.git/?a=blob;f=dlls/d3d8/tests/stateblock.c;#l1742
That test failed and during cleanup, NULL is referenced -> Crash

tex_count is 8 and all fail (0-7)
The R100 is an DX7 card (PS: 1.1 / VS: not supported)

Hints from KittyCat on IRC:
 http://msdn.microsoft.com/en-us/library/ms889290.aspx  doesn't list
D3DUSAGE_DYNAMIC as valid for *IDirect3DDevice::SetTexture

might need to change the pool, too
default pool can't be locked, unless it's also dynamic
so if it uses dynamic usage to make it lockable, it will need to be in a
different pool

--------------------------

Oh, a different Machine crashed at the same location.

See tests.winehq,org:
http://test.winehq.org/data/f222a1654ea8f84bc678c9043ad3265b97207dde/xp_XP-home-SP2-czechIE8/d3d8:stateblock.html
3d9 crashed also:
http://test.winehq.org/data/f222a1654ea8f84bc678c9043ad3265b97207dde/xp_XP-home-SP2-czechIE8/d3d9:stateblock.html
But next to the Virtual Machines, where all tests are skipped, I found a
system that works:
http://test.winehq.org/data/f222a1654ea8f84bc678c9043ad3265b97207dde/xp_af-xpsp3/d3d8:stateblock.html



Henry, do you have a nice Idea?

-- 
 
By by ... Detlef


More information about the wine-patches mailing list