user32: fix uninitialized variable so first call to DdeGetLastError isn't undefined

Dan Kegel dank at kegel.com
Thu Nov 5 21:16:34 CST 2009


Congrats to Mikey for getting his tests committed.  The first valgrind
run of them,
http://kegel.com/wine/valgrind/logs/2009-11-05-09.09/vg-shell32_progman_dde.txt
found an uninit variable:

 Conditional jump or move depends on uninitialised value(s)
    at  GetStringFromError (progman_dde.c:115)
    by  GetDdeLastErrorStr (progman_dde.c:149)
    by  func_progman_dde (progman_dde.c:535)
  Uninitialised value was created by a client request
    at  mark_block_uninitialized (heap.c:187)
    by  RtlAllocateHeap (heap.c:1429)
    by  WDML_Initialize (dde_misc.c:363)
    by  DdeInitializeA (dde_misc.c:593)
    by  func_progman_dde (progman_dde.c:530)

Here's the simple fix.
(There were also a bunch of memory leaks in that log... Mikey, could
you look at those?)
- Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dde.patch
Type: text/x-patch
Size: 515 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091105/980fa2c2/attachment.bin>


More information about the wine-patches mailing list