[PATCH 2/2] winmm: Enable more MCI waveaudio tests.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Nov 16 06:48:36 CST 2009


Hi,

The binary which I sent Paul on Friday passes with 0 failures on 3 real
machines: w95, w2k and xp.
Here's it is as patch, with the following modifications:
a) Print symbolic MCIERR_ constants (what patch 1 started);
b) Remove 2-3 notification tests because they are part of a later
   mciwave patch in my queue and Wine for now incorrectly handles the
situation;
c) Replace one Sound command using the defined SystemExclamation
   name with an undefined one - that also produces a sound on native;
d) Alternate order of two play/record commands to improve state machine
coverage.

Tested again on w2k.

This patch should fix the play/notify flakyness currently seen on
testhq. I mean this:
mci.c:155: Test failed: PeekMessage should succeed for command play from
0 to 0
mci.c:349: Test failed: mci status mode: playing
mci.c:136: Test failed: Expect no message from command play outofrange
notify #2
mci.c:142: Test failed: got 0004 instead of MCI_NOTIFY_xyz 0000 from
command play outofrange notify #2

Regards,
	Jorg Hohle.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-winmm-Enable-more-MCI-waveaudio-tests.patch
Type: application/octet-stream
Size: 17059 bytes
Desc: 0003-winmm-Enable-more-MCI-waveaudio-tests.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20091116/9430f3d6/attachment.obj>


More information about the wine-patches mailing list