shell32/tests: Remove atime tests in ITEMIDLIST_format test.

Austin Lund austin.lund at gmail.com
Thu Nov 19 06:23:48 CST 2009


-------------- next part --------------
From 20836a78d6cc6f18d1a20127ba88320bce9706c1 Mon Sep 17 00:00:00 2001
From: Austin Lund <austin.lund at gmail.com>
Date: Thu, 19 Nov 2009 22:16:01 +1000
Subject: [PATCH] shell32/tests: Remove atime tests in ITEMIDLIST_format test.

FAT filesystems only store access times for the day they were last
accessed.  For the function in the ITEMIDLIST_format test this time
is the system time of midnight for that day, then converted into the
local time for the running system.  This means that this atime test
will fail and the particular way it will fail will depend on the
local time of the machine it is run on (potentially random).
---
 dlls/shell32/tests/shlfolder.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/dlls/shell32/tests/shlfolder.c b/dlls/shell32/tests/shlfolder.c
index ed3a8b5..ff0892b 100644
--- a/dlls/shell32/tests/shlfolder.c
+++ b/dlls/shell32/tests/shlfolder.c
@@ -1524,10 +1524,6 @@ static void test_ITEMIDLIST_format(void) {
                     pFileStructA->uFileTime == pFileStructW->uTime,
                     "Last write time should match creation time!\n");
 
-                ok (pFileStructA->uFileDate == pFileStructW->uDate2 &&
-                    pFileStructA->uFileTime == pFileStructW->uTime2,
-                    "Last write time should match last access time!\n");
-
                 ok (!lstrcmpW(wszFile[i], pFileStructW->wszName) ||
                     !lstrcmpW(wszFile[i], (WCHAR *)(pFileStructW->abFooBar2 + 22)), /* Vista */
                     "The filename should be stored in unicode at this position!\n");
-- 
1.6.3.3


More information about the wine-patches mailing list