[PATCH 7/8] Silence FIXME for supported properties

Nikolay Sivov nsivov at codeweavers.com
Sun Aug 29 16:33:28 CDT 2010


---
 dlls/msxml3/saxreader.c |   22 ++++++++++++----------
 1 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c
index 372884d..815d062 100644
--- a/dlls/msxml3/saxreader.c
+++ b/dlls/msxml3/saxreader.c
@@ -2146,10 +2146,7 @@ static HRESULT internal_putProperty(
         'x','m','l','d','e','c','l','-','v','e','r','s','i','o','n',0
     };
 
-    FIXME("(%p)->(%s): semi-stub\n", This, debugstr_w(pProp));
-
-    if(!memcmp(pProp, wszCharset, sizeof(wszCharset)))
-        return E_NOTIMPL;
+    TRACE("(%p)->(%s)\n", This, debugstr_w(pProp));
 
     if(!memcmp(pProp, wszDeclarationHandler, sizeof(wszDeclarationHandler)))
     {
@@ -2177,12 +2174,6 @@ static HRESULT internal_putProperty(
         return S_OK;
     }
 
-    if(!memcmp(pProp, wszDomNode, sizeof(wszDomNode)))
-        return E_FAIL;
-
-    if(!memcmp(pProp, wszInputSource, sizeof(wszInputSource)))
-        return E_NOTIMPL;
-
     if(!memcmp(pProp, wszLexicalHandler, sizeof(wszLexicalHandler)))
     {
         if(This->isParsing) return E_FAIL;
@@ -2211,6 +2202,17 @@ static HRESULT internal_putProperty(
         return S_OK;
     }
 
+    FIXME("(%p)->(%s): unsupported property\n", This, debugstr_w(pProp));
+
+    if(!memcmp(pProp, wszCharset, sizeof(wszCharset)))
+        return E_NOTIMPL;
+
+    if(!memcmp(pProp, wszDomNode, sizeof(wszDomNode)))
+        return E_FAIL;
+
+    if(!memcmp(pProp, wszInputSource, sizeof(wszInputSource)))
+        return E_NOTIMPL;
+
     if(!memcmp(pProp, wszMaxElementDepth, sizeof(wszMaxElementDepth)))
         return E_NOTIMPL;
 
-- 
1.5.6.5



--------------020006060803070707080004--



More information about the wine-patches mailing list