[PATCH 4/5] winmm: Accept the ancient, smaller MIDIHDR.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Mon Feb 22 06:10:18 CST 2010


Hi,

Searching the net for documentation, I came across many examples
in VB, Perl and Python which use the smaller structure that seems
to originate from Win16 times.
Even MSDN shows dwReserved[4] instead of now [8]. Obviously, this
structure changed over time.  Tests (in my next patch) show that
the old structure size is still supported.

With that patch in place, I wonder how many old apps will now
start to produce MIDI music?


I felt that a split into per-device patches was bad for
git cherry-pick. Either change all of them in sync, or none.

Actually, I've not yet groked the logic for/against splitting
a patch. Sometimes tiny patches are split, sometimes larger
changes are not and modify plenty of files everywhere.

Of course I can split if you wish.

Regards,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-winmm-Accept-the-ancient-smaller-MIDIHDR.patch
Type: application/octet-stream
Size: 10807 bytes
Desc: 0007-winmm-Accept-the-ancient-smaller-MIDIHDR.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100222/de2fbdf3/attachment.obj>


More information about the wine-patches mailing list