[PATCH 1/2] ole32/tests: Improve the HGLOBAL stream tests for Seek. [try 3]
Reece Dunn
msclrhd at googlemail.com
Thu Feb 25 03:20:23 CST 2010
try 1: initial tests
try 2: improve tests for invalid arguments
try 3:
(a) in the seek end test, start at the beginning of the stream to
test that it moves to the end;
(b) check that seek does not happen for invalid seek types.
- Reece
-------------- next part --------------
From e11a4a238241caf8fe783a0eda99b0c6c8e5996b Mon Sep 17 00:00:00 2001
From: Reece Dunn <msclrhd at gmail.com>
Date: Thu, 25 Feb 2010 09:02:13 +0000
Subject: [PATCH 1/2] ole32/tests: Improve the HGLOBAL stream tests for Seek.
---
dlls/ole32/tests/hglobalstream.c | 158 ++++++++++++++++++++++++++++++++++++-
1 files changed, 153 insertions(+), 5 deletions(-)
diff --git a/dlls/ole32/tests/hglobalstream.c b/dlls/ole32/tests/hglobalstream.c
index 4fee612..d95a7c4 100644
--- a/dlls/ole32/tests/hglobalstream.c
+++ b/dlls/ole32/tests/hglobalstream.c
@@ -75,22 +75,170 @@ static void test_streamonhglobal(IStream *pStream)
hr = IStream_SetSize(pStream, ull);
ok_ole_success(hr, "IStream_SetSize");
- /* ignores HighPart */
- ll.u.HighPart = -1;
+ /* IStream_Seek -- NULL position argument */
+ ll.u.HighPart = 0;
ll.u.LowPart = 0;
- hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, NULL);
+ ok_ole_success(hr, "IStream_Seek");
+
+ /* IStream_Seek -- valid position argument (seek from current position) */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == sizeof(data), "should have set LowPart to %d instead of %d\n", sizeof(data), ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- invalid seek argument */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 123;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_END+1, &ull);
todo_wine
+ ok(hr == STG_E_SEEKERROR, "IStream_Seek should have returned STG_E_SEEKERROR instead of 0x%08x\n", hr);
+ todo_wine
+ ok(ull.u.LowPart == sizeof(data), "should have set LowPart to %d instead of %d\n", sizeof(data), ull.u.LowPart);
+ todo_wine
+ ok(ull.u.HighPart == 0, "should not have changed HighPart, got %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- valid position argument (seek to beginning) */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
ok_ole_success(hr, "IStream_Seek");
ok(ull.u.LowPart == 0, "should have set LowPart to 0 instead of %d\n", ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- valid position argument (seek to end) */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_END, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == 0, "should have set LowPart to 0 instead of %d\n", ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- ignore HighPart in the move value (seek from current position) */
+ ll.u.HighPart = 0;
+ ll.u.LowPart = sizeof(data);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = -1;
+ ll.u.LowPart = 0;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ todo_wine
+ ok_ole_success(hr, "IStream_Seek");
+ todo_wine
+ ok(ull.u.LowPart == sizeof(data), "should have set LowPart to %d instead of %d\n", sizeof(data), ull.u.LowPart);
todo_wine
ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
- /* ignores HighPart */
+ /* IStream_Seek -- ignore HighPart in the move value (seek to beginning) */
+ ll.u.HighPart = 0;
+ ll.u.LowPart = sizeof(data);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
ll.u.HighPart = -1;
ll.u.LowPart = 0;
- hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, NULL);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
todo_wine
ok_ole_success(hr, "IStream_Seek");
+ todo_wine
+ ok(ull.u.LowPart == 0, "should have set LowPart to 0 instead of %d\n", ull.u.LowPart);
+ todo_wine
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- invalid LowPart value (seek from current position) */
+ ll.u.HighPart = 0;
+ ll.u.LowPart = sizeof(data);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0x80000000;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ todo_wine
+ ok(hr == STG_E_SEEKERROR, "IStream_Seek should have returned STG_E_SEEKERROR instead of 0x%08x\n", hr);
+ todo_wine
+ ok(ull.u.LowPart == sizeof(data), "should have set LowPart to %d instead of %d\n", sizeof(data), ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- invalid LowPart value (seek to beginning) */
+ ll.u.HighPart = 0;
+ ll.u.LowPart = sizeof(data);
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0x80000000;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ todo_wine
+ ok(hr == STG_E_SEEKERROR, "IStream_Seek should have returned STG_E_SEEKERROR instead of 0x%08x\n", hr);
+ todo_wine
+ ok(ull.u.LowPart == sizeof(data), "should have set LowPart to %d instead of %d\n", sizeof(data), ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- valid LowPart value (seek to beginning) */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0x7FFFFFFF;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == 0x7FFFFFFF, "should have set LowPart to 0x7FFFFFFF instead of %08x\n", ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- valid LowPart value (seek from current position) */
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_SET, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0x7FFFFFFF;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == 0x7FFFFFFF, "should have set LowPart to 0x7FFFFFFF instead of %08x\n", ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- second seek allows you to go past 0x7FFFFFFF size */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 9;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == 0x80000008, "should have set LowPart to 0x80000008 instead of %08x\n", ull.u.LowPart);
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
+
+ /* IStream_Seek -- seek wraps position/size on integer overflow */
+ ull.u.HighPart = 0xCAFECAFE;
+ ull.u.LowPart = 0xCAFECAFE;
+ ll.u.HighPart = 0;
+ ll.u.LowPart = 0x7FFFFFFF;
+ hr = IStream_Seek(pStream, ll, STREAM_SEEK_CUR, &ull);
+ ok_ole_success(hr, "IStream_Seek");
+ ok(ull.u.LowPart == 0x00000007, "should have set LowPart to 0x00000007 instead of %08x\n", ull.u.LowPart);
+ todo_wine
+ ok(ull.u.HighPart == 0, "should have set HighPart to 0 instead of %d\n", ull.u.HighPart);
hr = IStream_Commit(pStream, STGC_DEFAULT);
ok_ole_success(hr, "IStream_Commit");
--
1.6.3.3
More information about the wine-patches
mailing list