[PATCH] mlang: [try 2] Print a FIXME only for unused parameter (Wine FIXME Report)
Detlef Riekenberg
wine.dev at web.de
Wed Jan 6 17:47:07 CST 2010
According to MSDN, both parameter are unused and must be 0/NULL
A FIXME for every call is useless
try2:
Do not compare the pointer with NULL, as suggested by james
--
By by ... Detlef
---
dlls/mlang/mlang.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dlls/mlang/mlang.c b/dlls/mlang/mlang.c
index 49f0605..47b1745 100644
--- a/dlls/mlang/mlang.c
+++ b/dlls/mlang/mlang.c
@@ -3007,9 +3007,6 @@ exit:
return hr;
}
-/*
- * TODO: handle dwFlag and lpFallBack
-*/
static HRESULT WINAPI fnIMultiLanguage2_ConvertStringToUnicodeEx(
IMultiLanguage3* iface,
DWORD* pdwMode,
@@ -3021,7 +3018,10 @@ static HRESULT WINAPI fnIMultiLanguage2_ConvertStringToUnicodeEx(
DWORD dwFlag,
WCHAR* lpFallBack)
{
- FIXME("\n");
+ if (dwFlag || lpFallBack)
+ FIXME("Ignoring dwFlag (0x%x/%d) and lpFallBack (%p)\n",
+ dwFlag, dwFlag, lpFallBack);
+
return ConvertINetMultiByteToUnicode(pdwMode, dwEncoding,
pSrcStr, (LPINT)pcSrcSize, pDstStr, (LPINT)pcDstSize);
}
--
1.6.5
More information about the wine-patches
mailing list