[PATCH2/2] midimap: Refuse to open when asked for yet unimplemented callbacks.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Thu Jan 28 03:38:11 CST 2010


Hi,

this patch may be enough to close bug #9220.

Of course, a better patch would be to implement the missing notification
in the midimapper, but I'm not familiar enough with winmm yet.

Nevertheless, this patch is correct and very valuable as is: instead of hanging,
some apps now either disable the MIDI toggle in their GUI or display
the text from midiOutErrorText() when attempting to select MIDI.  Thus, these
apps become useable, even though no music is heard.

It is much preferrable to have defined behaviour (return an error, visible in
the trace) than to hang waiting for a callback or notification that never comes.
It is very hard to find the reason of hangs -- I was lucky here.

At some later point in time, I hope to implement the missing notification. I
already have built a tiny patch queue of small MIDI-related issues.

Enjoy,
	Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-midimap-Refuse-to-open-when-asked-for-yet-unimpleme.patch
Type: application/text
Size: 901 bytes
Desc: 0002-midimap-Refuse-to-open-when-asked-for-yet-unimpleme.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100128/ecd396e1/attachment-0001.bin>


More information about the wine-patches mailing list