dlls/ntdll/file.c: Use FIXME_ONCE for quieter reports.

Max TenEyck Woodbury max at mtew.isa-geek.net
Wed Jul 14 14:02:40 CDT 2010


---
 dlls/ntdll/file.c |   40 ++++++++++++++++++----------------------
 1 files changed, 18 insertions(+), 22 deletions(-)

diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
index 0a6ee55..0b59765 100644
--- a/dlls/ntdll/file.c
+++ b/dlls/ntdll/file.c
@@ -117,7 +117,7 @@ static NTSTATUS FILE_CreateFile( PHANDLE handle, ACCESS_MASK access, POBJECT_ATT
 
     if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER;
 
-    if (alloc_size) FIXME( "alloc_size not supported\n" );
+    if (alloc_size) FIXME_ONCE( "alloc_size not supported\n" );
 
     if (options & FILE_OPEN_BY_FILE_ID)
         io->u.Status = file_id_to_unix_file_name( attr, &unix_name );
@@ -1484,7 +1484,7 @@ NTSTATUS WINAPI NtFsControlFile(HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc
         break;
 
     case FSCTL_PIPE_IMPERSONATE:
-        FIXME("FSCTL_PIPE_IMPERSONATE: impersonating self\n");
+        FIXME_ONCE("FSCTL_PIPE_IMPERSONATE: impersonating self\n");
         status = RtlImpersonateSelf( SecurityImpersonation );
         break;
 
@@ -1531,7 +1531,7 @@ NTSTATUS WINAPI NtSetVolumeInformationFile(
         ULONG Length,
 	FS_INFORMATION_CLASS FsInformationClass)
 {
-	FIXME("(%p,%p,%p,0x%08x,0x%08x) stub\n",
+	FIXME_ONCE("(%p,%p,%p,0x%08x,0x%08x) stub\n",
 	FileHandle,IoStatusBlock,FsInformation,Length,FsInformationClass);
 	return 0;
 }
@@ -2397,8 +2397,7 @@ static NTSTATUS get_device_info( int fd, FILE_FS_DEVICE_INFORMATION *info )
             }
         }
 #else
-        static int warned;
-        if (!warned++) FIXME( "device info not properly supported on this platform\n" );
+        FIXME_ONCE( "device info not properly supported on this platform\n" );
         info->DeviceType = FILE_DEVICE_DISK_FILE_SYSTEM;
 #endif
         info->Characteristics |= FILE_DEVICE_IS_MOUNTED;
@@ -2430,7 +2429,6 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io
 {
     int fd, needs_close;
     struct stat st;
-    static int once;
 
     if ((io->u.Status = server_get_unix_fd( handle, 0, &fd, &needs_close, NULL, NULL )) != STATUS_SUCCESS)
         return io->u.Status;
@@ -2441,10 +2439,10 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io
     switch( info_class )
     {
     case FileFsVolumeInformation:
-        if (!once++) FIXME( "%p: volume info not supported\n", handle );
+        FIXME_ONCE( "%p: volume info not supported\n", handle );
         break;
     case FileFsLabelInformation:
-        FIXME( "%p: label info not supported\n", handle );
+        FIXME_ONCE( "%p: label info not supported\n", handle );
         break;
     case FileFsSizeInformation:
         if (length < sizeof(FILE_FS_SIZE_INFORMATION))
@@ -2513,19 +2511,19 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io
         }
         break;
     case FileFsAttributeInformation:
-        FIXME( "%p: attribute info not supported\n", handle );
+        FIXME_ONCE( "%p: attribute info not supported\n", handle );
         break;
     case FileFsControlInformation:
-        FIXME( "%p: control info not supported\n", handle );
+        FIXME_ONCE( "%p: control info not supported\n", handle );
         break;
     case FileFsFullSizeInformation:
-        FIXME( "%p: full size info not supported\n", handle );
+        FIXME_ONCE( "%p: full size info not supported\n", handle );
         break;
     case FileFsObjectIdInformation:
-        FIXME( "%p: object id info not supported\n", handle );
+        FIXME_ONCE( "%p: object id info not supported\n", handle );
         break;
     case FileFsMaximumInformation:
-        FIXME( "%p: maximum info not supported\n", handle );
+        FIXME_ONCE( "%p: maximum info not supported\n", handle );
         break;
     default:
         io->u.Status = STATUS_INVALID_PARAMETER;
@@ -2560,7 +2558,7 @@ NTSTATUS WINAPI NtQueryEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer
                                BOOLEAN single_entry, PVOID ea_list, ULONG ea_list_len,
                                PULONG ea_index, BOOLEAN restart )
 {
-    FIXME("(%p,%p,%p,%d,%d,%p,%d,%p,%d) stub\n",
+    FIXME_ONCE("(%p,%p,%p,%d,%d,%p,%d,%p,%d) stub\n",
             hFile, iosb, buffer, length, single_entry, ea_list,
             ea_list_len, ea_index, restart);
     return STATUS_ACCESS_DENIED;
@@ -2584,7 +2582,7 @@ NTSTATUS WINAPI NtQueryEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer
  */
 NTSTATUS WINAPI NtSetEaFile( HANDLE hFile, PIO_STATUS_BLOCK iosb, PVOID buffer, ULONG length )
 {
-    FIXME("(%p,%p,%p,%d) stub\n", hFile, iosb, buffer, length);
+    FIXME_ONCE("(%p,%p,%p,%d) stub\n", hFile, iosb, buffer, length);
     return STATUS_ACCESS_DENIED;
 }
 
@@ -2636,18 +2634,16 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event,
     NTSTATUS    ret;
     HANDLE      handle;
     BOOLEAN     async;
-    static BOOLEAN     warn = TRUE;
 
     if (apc || io_status || key)
     {
-        FIXME("Unimplemented yet parameter\n");
+        FIXME_ONCE("Unimplemented yet parameter\n");
         return STATUS_NOT_IMPLEMENTED;
     }
 
-    if (apc_user && warn)
+    if (apc_user )
     {
-        FIXME("I/O completion on lock not implemented yet\n");
-        warn = FALSE;
+        FIXME_ONCE("I/O completion on lock not implemented yet\n");
     }
 
     for (;;)
@@ -2672,7 +2668,7 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event,
 
         if (async)
         {
-            FIXME( "Async I/O lock wait not implemented, might deadlock\n" );
+            FIXME_ONCE( "Async I/O lock wait not implemented, might deadlock\n" );
             if (handle) NtClose( handle );
             return STATUS_PENDING;
         }
@@ -2710,7 +2706,7 @@ NTSTATUS WINAPI NtUnlockFile( HANDLE hFile, PIO_STATUS_BLOCK io_status,
 
     if (io_status || key)
     {
-        FIXME("Unimplemented yet parameter\n");
+        FIXME_ONCE("Unimplemented yet parameter\n");
         return STATUS_NOT_IMPLEMENTED;
     }
 
-- 
1.7.1.1




More information about the wine-patches mailing list