[Resend] dlls/ntdll/file.c: Use FIXME_ONCE for one-time-only FIXME.

Max TenEyck Woodbury max at mtew.isa-geek.net
Sat Jul 17 01:20:10 CDT 2010


---
 dlls/ntdll/file.c |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
index 0a6ee55..bf2ccd8 100644
--- a/dlls/ntdll/file.c
+++ b/dlls/ntdll/file.c
@@ -2397,8 +2397,7 @@ static NTSTATUS get_device_info( int fd, FILE_FS_DEVICE_INFORMATION *info )
             }
         }
 #else
-        static int warned;
-        if (!warned++) FIXME( "device info not properly supported on this platform\n" );
+        FIXME_ONCE( "device info not properly supported on this platform\n" );
         info->DeviceType = FILE_DEVICE_DISK_FILE_SYSTEM;
 #endif
         info->Characteristics |= FILE_DEVICE_IS_MOUNTED;
@@ -2430,7 +2429,6 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io
 {
     int fd, needs_close;
     struct stat st;
-    static int once;
 
     if ((io->u.Status = server_get_unix_fd( handle, 0, &fd, &needs_close, NULL, NULL )) != STATUS_SUCCESS)
         return io->u.Status;
@@ -2441,7 +2439,7 @@ NTSTATUS WINAPI NtQueryVolumeInformationFile( HANDLE handle, PIO_STATUS_BLOCK io
     switch( info_class )
     {
     case FileFsVolumeInformation:
-        if (!once++) FIXME( "%p: volume info not supported\n", handle );
+        FIXME_ONCE( "%p: volume info not supported\n", handle );
         break;
     case FileFsLabelInformation:
         FIXME( "%p: label info not supported\n", handle );
@@ -2636,7 +2634,6 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event,
     NTSTATUS    ret;
     HANDLE      handle;
     BOOLEAN     async;
-    static BOOLEAN     warn = TRUE;
 
     if (apc || io_status || key)
     {
@@ -2644,10 +2641,9 @@ NTSTATUS WINAPI NtLockFile( HANDLE hFile, HANDLE lock_granted_event,
         return STATUS_NOT_IMPLEMENTED;
     }
 
-    if (apc_user && warn)
+    if (apc_user)
     {
-        FIXME("I/O completion on lock not implemented yet\n");
-        warn = FALSE;
+        FIXME_ONCE("I/O completion on lock not implemented yet\n");
     }
 
     for (;;)
-- 
1.7.1.1




More information about the wine-patches mailing list