[PATCH 1/1] d3dx9: Complete test for D3DXCreateSphere. (try 2)

Misha Koshelev misha680 at gmail.com
Thu Jul 22 20:30:09 CDT 2010


Dear All:

I have addressed Henri's first comment in the patch:
> An assert probably isn't very useful after the fact, but it seems to
> me that dynamically allocating an array of the appropriate size is
> nicer anyway.
Specifically, I have dynamically allocated the appropriate arrays.

> > +static DWORD compute_sphere_test_index_data(FLOAT radius, UINT slices, UINT stacks)
> I haven't really thought this through yet, but would it perhaps be
> simpler to calculate the faces a vertex is part of, instead of the
> other way around?
I am not 100% sure of a way to do this. I have looked at the data (also will send to wine-devel) but do not
immediately see a pattern that would be simpler than generating the index data. I, of course, welcome suggestions
from wine-devel if I am missing something.

Thank you
Misha
---
 dlls/d3dx9_36/tests/mesh.c |  354 +++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 350 insertions(+), 4 deletions(-)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-d3dx9-Complete-test-for-D3DXCreateSphere.txt
Type: text/x-patch
Size: 14656 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100722/59069ae1/attachment-0001.bin>


More information about the wine-patches mailing list