[PATCH 1/2 (try 2)] comdlg32: Store and use save/open dialogs' most-recently-used data

Andrew Eikum aeikum at codeweavers.com
Fri Jul 23 13:13:04 CDT 2010


This fixes bug 10284, and will cause all comdlg32 open and save dialogs
to restore the most-recently-used directory, as they do on Windows.

The order of the initial directory resolution has been changed slightly
to more accurately match Windows.  According to MSDN (and manual testing
on Windows XP confirms), the MRU directory should be used _before_ falling
back on the current directory, as the old comments indicated.

The implementation here follows that of Windows 2000-XP.  Windows Vista+
changes the implementation to be considerably more complex, with several
more registry keys and PIDLs serialized into the registry.  I
considered how this data is stored in the registry to be an implementation
detail (hence no tests for the actual registry storage), and chose the
Windows XP keys & format to simplify the implementation.
---

(try 2): Apparently I forgot how sizeof() works in try1.  Sorry about 
that. =/

    dlls/comdlg32/filedlg.c       |  226 
++++++++++++++++++++++++++++++++++++++++-
    dlls/comdlg32/tests/filedlg.c |   60 +++++++++++
    2 files changed, 283 insertions(+), 3 deletions(-)




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-comdlg32-Store-and-use-save-open-dialogs-most-recent.patch
Type: text/x-patch
Size: 13004 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100723/56636606/attachment-0001.bin>


More information about the wine-patches mailing list