Final version of Minor dlls/mshtml/htmlbody.c simplification

Gerald Pfeifer gerald at pfeifer.com
Sat May 1 09:19:05 CDT 2010


On Sat, 1 May 2010, Nikolay Sivov wrote:
>> Is the following what you had in mind?
> Yes, but you don't have to initialize it to S_OK.

Doh, of course!  Thanks again for your guidance, and sorry for being
extra slow on this one.

Final patch below.

Gerald


commit 7a15df0a7087d93d4003ecf06e79a198bda3732c
Author: Gerald Pfeifer <gerald at pfeifer.com>
Date:   Sat May 1 16:16:21 2010 +0200

    GERALD: Fix return value for HTMLBodyElement_get_text.

diff --git a/dlls/mshtml/htmlbody.c b/dlls/mshtml/htmlbody.c
index 5c66e65..e4bb1d0 100644
--- a/dlls/mshtml/htmlbody.c
+++ b/dlls/mshtml/htmlbody.c
@@ -462,7 +462,7 @@ static HRESULT WINAPI HTMLBodyElement_get_text(IHTMLBodyElement *iface, VARIANT
 
     nsAString_Finish(&text);
 
-    return S_OK;
+    return hres;
 }
 
 static HRESULT WINAPI HTMLBodyElement_put_link(IHTMLBodyElement *iface, VARIANT v)



More information about the wine-patches mailing list