shlwapi: Remove variable retval which is not really used from GetAcceptLanguagesW.

Gerald Pfeifer gerald at pfeifer.com
Sun May 9 11:18:48 CDT 2010


I looked into improving the error handling here, but given the
implementation and circumstances (also other return values are
not checked) it seems going for the simplification is more suitable.

Gerald
---
 dlls/shlwapi/ordinal.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/shlwapi/ordinal.c b/dlls/shlwapi/ordinal.c
index 332bdb6..22851d9 100644
--- a/dlls/shlwapi/ordinal.c
+++ b/dlls/shlwapi/ordinal.c
@@ -484,7 +484,6 @@ HRESULT WINAPI GetAcceptLanguagesW( LPWSTR langbuf, LPDWORD buflen)
     DWORD mystrlen, mytype;
     DWORD len;
     HKEY mykey;
-    HRESULT retval;
     LCID mylcid;
     WCHAR *mystr;
     LONG lres;
@@ -512,7 +511,7 @@ HRESULT WINAPI GetAcceptLanguagesW( LPWSTR langbuf, LPDWORD buflen)
 
     /* Did not find a value in the registry or the user buffer is too small */
     mylcid = GetUserDefaultLCID();
-    retval = LcidToRfc1766W(mylcid, mystr, mystrlen);
+    LcidToRfc1766W(mylcid, mystr, mystrlen);
     len = lstrlenW(mystr);
 
     memcpy( langbuf, mystr, min(*buflen, len+1)*sizeof(WCHAR) );
-- 
1.6.6.2



More information about the wine-patches mailing list