[PATCH 2/3] winmm: A NULL CALLBACK_FUNCTION is acceptable since w2k.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue May 18 08:10:39 CDT 2010


Hi,

My border case testing revealed this case.

That's a simple and central protection against that case.  Another
way would be to behave like Win9x (like my testing in part 3
shows): check that case at open time and return INVALID_PARAM.
E.g. Maarten did a check (for another case) at open time in his
winmm/mmdev bridge driver (not applied so far).
Both ways are fine, the non-central one would be more efficient,
at the expense of more code.

I removed the old warning about non NULL cb with DCB_NULL because
there's no point in looking at some extra parameter when the main
dispatcher type indicates that it's of no use.

Regards,
 Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-winmm-A-NULL-CALLBACK_FUNCTION-is-acceptable-since.patch
Type: application/octet-stream
Size: 1275 bytes
Desc: 0004-winmm-A-NULL-CALLBACK_FUNCTION-is-acceptable-since.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100518/7bb5ebfa/attachment.obj>


More information about the wine-patches mailing list