[PATCH 3/3] winmm: More MIDI boundary tests & fixes.

Joerg-Cyril.Hoehle at t-systems.com Joerg-Cyril.Hoehle at t-systems.com
Tue May 18 08:21:13 CDT 2010


Hi,

This adds the test
if (MOD_MIDIPORT == capsA.wTechnology)
  ok(!(capsA.dwSupport & (MIDICAPS_VOLUME|MIDICAPS_LRVOLUME|MIDICAPS_CACHE))
and therefore depends on my former OSS+ALSA MOD_MIDIPORT patches.

The MIDISHORTEVENT type permits to easily add new tests with notes/keys.

For now, I've locally added the test
+    switch (dwFlags & CALLBACK_TYPEMASK) {
+    case CALLBACK_WINDOW:
+        if (dwCallback && !IsWindow((HWND)dwCallback))
I've not yet written tests for all other device types to verify
whether they behave similarly.  IIRC, the mixer tests shows some
different behaviour. Yet it might still be possible to write a central
"check_callback_parameters" function for all 5 types, such that
winmm:XYZOpen() fails with MMSYSERR_INVALPARAM.

Regards,
 Jörg Höhle.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-winmm-More-MIDI-boundary-tests-fixes.patch
Type: application/octet-stream
Size: 13872 bytes
Desc: 0005-winmm-More-MIDI-boundary-tests-fixes.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100518/b7bc98b0/attachment-0001.obj>


More information about the wine-patches mailing list