[PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup

Roderick Colenbrander thunderbird2k at gmail.com
Tue May 18 17:38:39 CDT 2010


This patch series removes the responsibility for enabling/disabling the
texture_target from the 'set_shader' stage of the blit_shader.

Right now set_shader is used in roughly two places namely swapchain_blit and by the three places
which call draw_textured_quad. When no real shaders are needed set_shader is only used as a
glEnable(GL_TEXTURE_2D) and friends. The places which use draw_textured_quad already take care
of texture target activation and also have better knowledge of which state to deactivate.

I'm aware that glEnable(GL_TEXTURE_2D) aren't needed when we need 'real' shaders. At a later
stage when the blit_shader is more complete these lines can be dropped from 'arbfp_blit_surface',
so for the real shader case it is a slight step back (though various places already made these calls already).

At a later stage I might disallow calling set_shader when we don't need the shader.

Regards,
Roderick Colenbrander




More information about the wine-patches mailing list