[2/2] urlmon/tests: Added tests for IUri_GetPropertyDWORD (try 3)

Thomas Mullaly thomas.mullaly at gmail.com
Wed May 26 16:42:12 CDT 2010


My last attempt at this patch was put under 'pending' status and I never
received feedback as to what was wrong with it, but, I changed a few things
I thought might have been causing it not from getting committed.

First:
I made the test data for the DWORD values of a URI more explicit. I used
enum values instead of hard coded numerical values.

Second:
This ties in with the first, urlmon.idl was missing the Uri_HOST_TYPE enum,
as described here:
http://msdn.microsoft.com/en-us/library/ms775140(VS.85).aspx, so I added it.
Also, the URLZONE enum in urlmon.idl wasn't up-to-date and was missing the
URLZONE_INVALID property, which was added with IE 7 (as describe here:
http://msdn.microsoft.com/en-us/library/ms537175(VS.85).aspx), so I added
it.

Third:
Fixed a possible memory access violation that could occur in
Uri_GetPropertyDWORD().

---
 dlls/urlmon/tests/uri.c |  116
++++++++++++++++++++++++++++++++++++++++++++++-
 dlls/urlmon/uri.c       |   15 ++++++
 include/urlmon.idl      |   10 ++++
 3 files changed, 140 insertions(+), 1 deletions(-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100526/eb27cc5f/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-urlmon-tests-Added-tests-for-IUri_GetPropretyDWORD.-.patch
Type: text/x-patch
Size: 10391 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100526/eb27cc5f/attachment.bin>


More information about the wine-patches mailing list