[4/4] d3d9: Add a sRGB format test

Stefan Dösinger stefandoesinger at gmx.at
Mon Nov 1 05:41:39 CDT 2010


Am 01.11.2010 um 10:41 schrieb Henri Verbeet:

> On 31 October 2010 22:53, Stefan Dösinger <stefan at codeweavers.com> wrote:
>> +    static const struct
>> +    {
>> +        float x, y, z;
>> +        float u, v;
>> +    }
>> +    quad[] =
>> +    {
>> +        {-1.0,   -1.0,   0.1,    0.0,    0.0},
>> +        {-1.0,    1.0,   0.1,    1.0,    0.0},
>> +        { 1.0,   -1.0,   0.1,    0.0,    1.0},
>> +        { 1.0,    1.0,   0.1,    1.0,    1.0}
>> +    };
> Not that I care all that much, but notice that those literals are
> actually doubles.
Now that I've fixed a number of those I guess we should stick to caring about that.
> 
>> +            hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, quad, sizeof(float) * 5);
> Now that you're using a proper structure for "quad", "sizeof(float) *
> 5" is really just the same as "sizeof(*quad)".
Sorry, I forgot to adjust that line - it's fixed now.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-d3d9-Add-a-sRGB-format-test.txt
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20101101/92050637/attachment.txt>


More information about the wine-patches mailing list