Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status

[Eric Pouech]

Le 21/11/2010 22:35, Borut Razem a écrit :
> Here is second try of the patch: dynamically allocated array of 
> process handles indexed by fd and direct access (no linear search), as 
> requested by Alexandre. I performed some tests and it seems to work 
> correctly.
>
> The patch I sent for review to wine-devel mailing list has a bug, so 
> please ignore it.
>
> Borut
>
> ---
>  dlls/msvcrt/process.c |  101 
> ++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 99 insertions(+), 2 deletions(-)
>
>
>
>
one minor comment:
you access file->_file after file has been closed, which can lead to 
races issues
you'd better copy the _file before closing the stream

A+

-- 
Eric Pouech
"The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20101122/02dfea67/attachment.htm>