[PATCH] wininet: added one missing buffersize check in URLCache_CopyEntry (Coverity)

Marcus Meissner marcus at jet.franken.de
Sun Oct 24 04:53:28 CDT 2010


Hi,

CID 831, indirectly spotted by Coverity, one missing
check for (*lpdwBufferSize >= dwRequiredSize) added.

Ciao, Marcus
---
 dlls/wininet/urlcache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c
index 2129f42..d565c5f 100644
--- a/dlls/wininet/urlcache.c
+++ b/dlls/wininet/urlcache.c
@@ -1007,7 +1007,7 @@ static DWORD URLCache_CopyEntry(
         ZeroMemory((LPBYTE)lpCacheEntryInfo + dwRequiredSize, 4 - (dwRequiredSize % 4));
     dwRequiredSize = DWORD_ALIGN(dwRequiredSize);
 
-    if (pUrlEntry->dwOffsetLocalName)
+    if (pUrlEntry->dwOffsetLocalName && (dwRequiredSize < *lpdwBufferSize))
     {
         LONG nLocalFilePathSize;
         LPSTR lpszLocalFileName;
-- 
1.7.1



More information about the wine-patches mailing list