[PATCH 7/7] CMD: Change the parameterization to be correct

Jason Edmeades jason.edmeades at googlemail.com
Fri Sep 3 18:47:54 CDT 2010


Previously if a token started with a quote, it was assumed the end
quote was the end of the parameter, which is incorrect - it is
perfectly valid to have eg. "c:\program files"\directory.

This patch fixes bug 22431. Note the same logic will need to be
added to anywhere in cmd where the parameter gets passed as a true
filename to a lower level function - however, it would be broken
today anyway and its seriously improved with this logic!
---
 programs/cmd/batch.c                     |   30 +++++++---------------
 programs/cmd/builtins.c                  |    4 ++-
 programs/cmd/tests/test_builtins.cmd     |   25 ++++++++++++++++++
 programs/cmd/tests/test_builtins.cmd.exp |   32 ++++++++++++++++++++++++
 programs/cmd/wcmd.h                      |    1 +
 programs/cmd/wcmdmain.c                  |   40 +++++++++++++++++++----------
 6 files changed, 97 insertions(+), 35 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-CMD-Change-the-parameterization-to-be-correct.txt
Type: text/x-patch
Size: 6832 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20100903/93a17613/attachment.bin>


More information about the wine-patches mailing list