widl: Avoid duplicate assignments in resolve_expression.

Gerald Pfeifer gerald at pfeifer.com
Sun Sep 19 05:06:52 CDT 2010


At the beginning of this function we have result.is_variable = FALSE,
so these assignments are redundant.  (An alternative patch would be
to remove the initial assignment and have every case fully initialize
the result structure.)

Gerald
---
 tools/widl/expr.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/tools/widl/expr.c b/tools/widl/expr.c
index 8511ce5..e1a5196 100644
--- a/tools/widl/expr.c
+++ b/tools/widl/expr.c
@@ -513,27 +513,22 @@ static struct expression_type resolve_expression(const struct expr_loc *expr_loc
     case EXPR_HEXNUM:
     case EXPR_NUM:
     case EXPR_TRUEFALSE:
-        result.is_variable = FALSE;
         result.is_temporary = FALSE;
         result.type = type_new_int(TYPE_BASIC_INT, 0);
         break;
     case EXPR_STRLIT:
-        result.is_variable = FALSE;
         result.is_temporary = TRUE;
         result.type = type_new_pointer(RPC_FC_UP, type_new_int(TYPE_BASIC_CHAR, 0), NULL);
         break;
     case EXPR_WSTRLIT:
-        result.is_variable = FALSE;
         result.is_temporary = TRUE;
         result.type = type_new_pointer(RPC_FC_UP, type_new_int(TYPE_BASIC_WCHAR, 0), NULL);
         break;
     case EXPR_CHARCONST:
-        result.is_variable = FALSE;
         result.is_temporary = TRUE;
         result.type = type_new_int(TYPE_BASIC_CHAR, 0);
         break;
     case EXPR_DOUBLE:
-        result.is_variable = FALSE;
         result.is_temporary = TRUE;
         result.type = type_new_basic(TYPE_BASIC_DOUBLE);
         break;
@@ -596,7 +591,6 @@ static struct expression_type resolve_expression(const struct expr_loc *expr_loc
         result.type = e->u.tref;
         break;
     case EXPR_SIZEOF:
-        result.is_variable = FALSE;
         result.is_temporary = FALSE;
         result.type = type_new_int(TYPE_BASIC_INT, 0);
         break;
@@ -634,7 +628,6 @@ static struct expression_type resolve_expression(const struct expr_loc *expr_loc
         result_right = resolve_expression(expr_loc, cont_type, e->u.ext);
         check_scalar_type(expr_loc, cont_type, result_left.type);
         check_scalar_type(expr_loc, cont_type, result_right.type);
-        result.is_variable = FALSE;
         result.is_temporary = FALSE;
         result.type = type_new_int(TYPE_BASIC_INT, 0);
         break;
-- 
1.7.2.2



More information about the wine-patches mailing list