[PATCH 1/6] msxml3/tests: prevent a double-free in test_get_ownerDocument()

Adam Martinson amartinson at codeweavers.com
Mon Sep 27 13:54:39 CDT 2010


---
 dlls/msxml3/tests/domdoc.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 205716a..fa357af 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -5755,14 +5755,10 @@ static void test_get_ownerDocument(void)
     VariantClear(&var);
 
     /* set to XPath and check that new instances use it */
-    V_VT(&var) = VT_BSTR;
-    V_BSTR(&var) = _bstr_("XPath");
-    hr = IXMLDOMDocument2_setProperty(doc, _bstr_("SelectionLanguage"), var);
+    hr = IXMLDOMDocument2_setProperty(doc, _bstr_("SelectionLanguage"), _variantbstr_("XPath"));
     ok( hr == S_OK, "got 0x%08x\n", hr);
 
-    V_VT(&var) = VT_BSTR;
-    V_BSTR(&var) = _bstr_("xmlns:wi=\'www.winehq.org\'");
-    hr = IXMLDOMDocument2_setProperty(doc, _bstr_("SelectionNamespaces"), var);
+    hr = IXMLDOMDocument2_setProperty(doc, _bstr_("SelectionNamespaces"), _variantbstr_("xmlns:wi=\'www.winehq.org\'"));
     todo_wine ok( hr == S_OK, "got 0x%08x\n", hr);
 
     hr = IXMLDOMDocument2_get_firstChild(doc, &node);
-- 
1.7.2.3


--------------090707030504030708050305--



More information about the wine-patches mailing list