gameux: Make GAMEUX_{initGameData,uninitGameData,RegisterGame}() static.

Francois Gouget fgouget at free.fr
Tue Sep 28 13:12:34 CDT 2010


Also remove the WINAPI on GAMEUX_RegisterGame() since it is unneeded.
---
 dlls/gameux/gameexplorer.c   |   34 +++++++++++++++++++++++++++-------
 dlls/gameux/gameux_private.h |   41 -----------------------------------------
 2 files changed, 27 insertions(+), 48 deletions(-)

diff --git a/dlls/gameux/gameexplorer.c b/dlls/gameux/gameexplorer.c
index 02025cc..dcac62d 100644
--- a/dlls/gameux/gameexplorer.c
+++ b/dlls/gameux/gameexplorer.c
@@ -45,9 +45,13 @@ extern BOOL WINAPI GUIDFromStringW(LPCWSTR psz, LPGUID pguid);
 /*******************************************************************************
  * GAMEUX_initGameData
  *
- * Internal helper function. Description available in gameux_private.h file
+ * Initializes GAME_DATA structure fields with proper values. Should be
+ * called always before first usage of this structure.
+ *
+ * Parameters:
+ *  GameData                        [I/O]   pointer to structure to initialize
  */
-void GAMEUX_initGameData(struct GAMEUX_GAME_DATA *GameData)
+static void GAMEUX_initGameData(struct GAMEUX_GAME_DATA *GameData)
 {
     GameData->sGDFBinaryPath = NULL;
     GameData->sGameInstallDirectory = NULL;
@@ -57,9 +61,13 @@ void GAMEUX_initGameData(struct GAMEUX_GAME_DATA *GameData)
 /*******************************************************************************
  * GAMEUX_uninitGameData
  *
- * Internal helper function. Description available in gameux_private.h file
+ * Properly frees all data stored or pointed by fields of GAME_DATA structure.
+ * Should be called before freeing this structure.
+ *
+ * Parameters:
+ *  GameData                        [I/O]   pointer to structure to uninitialize
  */
-void GAMEUX_uninitGameData(struct GAMEUX_GAME_DATA *GameData)
+static void GAMEUX_uninitGameData(struct GAMEUX_GAME_DATA *GameData)
 {
     HeapFree(GetProcessHeap(), 0, GameData->sGDFBinaryPath);
     HeapFree(GetProcessHeap(), 0, GameData->sGameInstallDirectory);
@@ -498,11 +506,23 @@ static HRESULT GAMEUX_RemoveRegistryRecord(GUID* pInstanceID)
     return hr;
 }
 /*******************************************************************************
- * GAMEUX_RegisterGame
+ *  GAMEUX_RegisterGame
  *
- * Internal helper function. Description available in gameux_private.h file
+ * Helper function. Registers game associated with given GDF binary in
+ * Game Explorer.
+ *
+ * Parameters:
+ *  sGDFBinaryPath                  [I]     path to binary containing GDF file in
+ *                                          resources
+ *  sGameInstallDirectory           [I]     path to directory, where game installed
+ *                                          it's files.
+ *  installScope                    [I]     scope of game installation
+ *  pInstanceID                     [I/O]   pointer to game instance identifier.
+ *                                          If pointing to GUID_NULL, then new
+ *                                          identifier will be generated automatically
+ *                                          and returned via this parameter
  */
-HRESULT WINAPI GAMEUX_RegisterGame(LPCWSTR sGDFBinaryPath,
+static HRESULT GAMEUX_RegisterGame(LPCWSTR sGDFBinaryPath,
         LPCWSTR sGameInstallDirectory,
         GAME_INSTALL_SCOPE installScope,
         GUID *pInstanceID)
diff --git a/dlls/gameux/gameux_private.h b/dlls/gameux/gameux_private.h
index c8923b5..dc0c1d1 100644
--- a/dlls/gameux/gameux_private.h
+++ b/dlls/gameux/gameux_private.h
@@ -46,47 +46,6 @@ struct GAMEUX_GAME_DATA
     BSTR bstrDescription;           /* game's description */
 };
 /*******************************************************************************
- * GAMEUX_initGameData
- *
- * Initializes GAME_DATA structure fields with proper values. Should be
- * called always before first usage of this structure. Implemented in gameexplorer.c
- *
- * Parameters:
- *  GameData                        [I/O]   pointer to structure to initialize
- */
-void GAMEUX_initGameData(struct GAMEUX_GAME_DATA *GameData);
-/*******************************************************************************
- * GAMEUX_uninitGameData
- *
- * Properly frees all data stored or pointed by fields of GAME_DATA structure.
- * Should be called before freeing this structure. Implemented in gameexplorer.c
- *
- * Parameters:
- *  GameData                        [I/O]   pointer to structure to uninitialize
- */
-void GAMEUX_uninitGameData(struct GAMEUX_GAME_DATA *GameData);
-/*******************************************************************************
- *  GAMEUX_RegisterGame
- *
- * Helper function. Registers game associated with given GDF binary in
- * Game Explorer. Implemented in gameexplorer.c
- *
- * Parameters:
- *  sGDFBinaryPath                  [I]     path to binary containing GDF file in
- *                                          resources
- *  sGameInstallDirectory           [I]     path to directory, where game installed
- *                                          it's files.
- *  installScope                    [I]     scope of game installation
- *  pInstanceID                     [I/O]   pointer to game instance identifier.
- *                                          If pointing to GUID_NULL, then new
- *                                          identifier will be generated automatically
- *                                          and returned via this parameter
- */
-HRESULT WINAPI GAMEUX_RegisterGame(LPCWSTR sGDFBinaryPath,
-        LPCWSTR sGameInstallDirectory,
-        GAME_INSTALL_SCOPE installScope,
-        GUID *pInstanceID);
-/*******************************************************************************
  * GAMEUX_FindGameInstanceId
  *
  * Helper function. Searches for instance identifier of given game in given
-- 
1.7.1




More information about the wine-patches mailing list