[PATCH] user32: remove side effect code out of asserts() (Coverity)
Marcus Meissner
meissner at suse.de
Wed Feb 23 10:38:23 CST 2011
Hi,
assert()s should not contain function code, so move it out
and just use ok().
Ciao, Marcus
---
dlls/user32/tests/menu.c | 26 +++++++++++++++++---------
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c
index 0502672..6fe3429 100644
--- a/dlls/user32/tests/menu.c
+++ b/dlls/user32/tests/menu.c
@@ -2038,6 +2038,7 @@ static void test_menu_input(void) {
HINSTANCE hInstance = GetModuleHandleA( NULL );
HANDLE hThread, hWnd;
DWORD tid;
+ ATOM aclass;
if (!pSendInput)
{
@@ -2055,11 +2056,14 @@ static void test_menu_input(void) {
wclass.lpszMenuName = 0;
wclass.cbClsExtra = 0;
wclass.cbWndExtra = 0;
- assert (RegisterClassA( &wclass ));
- assert (hWnd = CreateWindowA( wclass.lpszClassName, "MenuTest",
- WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, 0,
- 400, 200, NULL, NULL, hInstance, NULL) );
-
+ aclass = RegisterClassA( &wclass );
+ ok (aclass, "MenuTest class not created\n");
+ if (!aclass) return;
+ hWnd = CreateWindowA( wclass.lpszClassName, "MenuTest",
+ WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, 0,
+ 400, 200, NULL, NULL, hInstance, NULL);
+ ok (hWnd, "MenuTest window not created\n");
+ if (!hWnd) return;
/* fixed menus */
hMenus[3] = CreatePopupMenu();
AppendMenu(hMenus[3], MF_STRING, 0, "&Enabled");
@@ -2136,10 +2140,14 @@ static void test_menu_hilitemenuitem( void )
wclass.lpszMenuName = 0;
wclass.cbClsExtra = 0;
wclass.cbWndExtra = 0;
- assert (RegisterClassA( &wclass ));
- assert (hWnd = CreateWindowA( wclass.lpszClassName, "HiliteMenuTest",
- WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, 0,
- 400, 200, NULL, NULL, wclass.hInstance, NULL) );
+ aclass = RegisterClassA( &wclass );
+ ok (aclass, "HiliteMenuTest class could not be created\n");
+ if (!aclass) return;
+ hWnd = CreateWindowA( wclass.lpszClassName, "HiliteMenuTest",
+ WS_OVERLAPPEDWINDOW, CW_USEDEFAULT, 0,
+ 400, 200, NULL, NULL, wclass.hInstance, NULL);
+ ok (hWnd, "HiliteMenuTest window could not be created\n");
+ if (!hWnd) return;
hMenu = CreateMenu();
hPopupMenu = CreatePopupMenu();
--
1.7.1
More information about the wine-patches
mailing list