[PATCH 4/4] Get rid of not longer used internal IXMLDOMNode vtable

Nikolay Sivov nsivov at codeweavers.com
Wed Feb 23 06:13:36 CST 2011


---
 dlls/msxml3/msxml_private.h |    1 -
 dlls/msxml3/node.c          |   59 ++++--------------------------------------
 2 files changed, 6 insertions(+), 54 deletions(-)

diff --git a/dlls/msxml3/msxml_private.h b/dlls/msxml3/msxml_private.h
index a618120..a3c69d6 100644
--- a/dlls/msxml3/msxml_private.h
+++ b/dlls/msxml3/msxml_private.h
@@ -242,7 +242,6 @@ extern void set_xpathmode(xmlDocPtr doc, BOOL xpath);
 typedef struct _xmlnode
 {
     DispatchEx dispex;
-    IXMLDOMNode IXMLDOMNode_iface;
     IXMLDOMNode *iface;
     xmlNodePtr node;
 } xmlnode;
diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c
index 081f9d4..6aaf172 100644
--- a/dlls/msxml3/node.c
+++ b/dlls/msxml3/node.c
@@ -105,11 +105,6 @@ xmlnode *get_node_obj(IXMLDOMNode *node)
     return SUCCEEDED(hres) ? obj : NULL;
 }
 
-static inline xmlnode *impl_from_IXMLDOMNode( IXMLDOMNode *iface )
-{
-    return CONTAINING_RECORD(iface, xmlnode, IXMLDOMNode_iface);
-}
-
 HRESULT node_get_nodeName(xmlnode *This, BSTR *name)
 {
     if (!name)
@@ -1075,48 +1070,6 @@ HRESULT node_get_base_name(xmlnode *This, BSTR *name)
     return S_OK;
 }
 
-static const struct IXMLDOMNodeVtbl xmlnode_vtbl =
-{
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL,
-    NULL
-};
-
 void destroy_xmlnode(xmlnode *This)
 {
     if(This->node)
@@ -1128,7 +1081,6 @@ void init_xmlnode(xmlnode *This, xmlNodePtr node, IXMLDOMNode *node_iface, dispe
     if(node)
         xmldoc_add_ref( node->doc );
 
-    This->IXMLDOMNode_iface.lpVtbl = &xmlnode_vtbl;
     This->node = node;
     This->iface = node_iface;
 
@@ -1471,7 +1423,7 @@ static HRESULT WINAPI unknode_cloneNode(
     VARIANT_BOOL pbool, IXMLDOMNode** outNode)
 {
     unknode *This = unknode_from_IXMLDOMNode( iface );
-    return IXMLDOMNode_cloneNode( &This->node.IXMLDOMNode_iface, pbool, outNode );
+    return node_clone(&This->node, pbool, outNode );
 }
 
 static HRESULT WINAPI unknode_get_nodeTypeString(
@@ -1498,7 +1450,7 @@ static HRESULT WINAPI unknode_put_text(
     BSTR p)
 {
     unknode *This = unknode_from_IXMLDOMNode( iface );
-    return IXMLDOMNode_put_text( &This->node.IXMLDOMNode_iface, p );
+    return node_put_text(&This->node, p);
 }
 
 static HRESULT WINAPI unknode_get_specified(
@@ -1543,7 +1495,8 @@ static HRESULT WINAPI unknode_get_dataType(
     VARIANT* var1)
 {
     unknode *This = unknode_from_IXMLDOMNode( iface );
-    return IXMLDOMNode_get_dataType( &This->node.IXMLDOMNode_iface, var1 );
+    TRACE("(%p)->(%p)\n", This, var1);
+    return return_null_var(var1);
 }
 
 static HRESULT WINAPI unknode_put_dataType(
@@ -1619,7 +1572,7 @@ static HRESULT WINAPI unknode_get_prefix(
     BSTR* p)
 {
     unknode *This = unknode_from_IXMLDOMNode( iface );
-    return IXMLDOMNode_get_prefix( &This->node.IXMLDOMNode_iface, p );
+    return node_get_prefix(&This->node, p);
 }
 
 static HRESULT WINAPI unknode_get_baseName(
@@ -1627,7 +1580,7 @@ static HRESULT WINAPI unknode_get_baseName(
     BSTR* p)
 {
     unknode *This = unknode_from_IXMLDOMNode( iface );
-    return IXMLDOMNode_get_baseName( &This->node.IXMLDOMNode_iface, p );
+    return node_get_base_name(&This->node, p);
 }
 
 static HRESULT WINAPI unknode_transformNodeToObject(
-- 
1.5.6.5



--------------020206040002030600020804--



More information about the wine-patches mailing list