[PATCH 1/2] Remove broken test and parameter check

Nikolay Sivov nsivov at codeweavers.com
Sun Feb 27 14:38:30 CST 2011


---
 dlls/msxml3/nodelist.c     |    3 ---
 dlls/msxml3/tests/domdoc.c |    6 ------
 2 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/dlls/msxml3/nodelist.c b/dlls/msxml3/nodelist.c
index 53cf5f5..749b179 100644
--- a/dlls/msxml3/nodelist.c
+++ b/dlls/msxml3/nodelist.c
@@ -71,9 +71,6 @@ static HRESULT WINAPI xmlnodelist_QueryInterface(
 {
     TRACE("(%p)->(%s %p)\n", iface, debugstr_guid(riid), ppvObject);
 
-    if(!ppvObject)
-        return E_INVALIDARG;
-
     if ( IsEqualGUID( riid, &IID_IUnknown ) ||
          IsEqualGUID( riid, &IID_IDispatch ) ||
          IsEqualGUID( riid, &IID_IXMLDOMNodeList ) )
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 6aad135..abd1f4b 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -1942,9 +1942,6 @@ todo_wine
 
     if (list)
     {
-        r = IXMLDOMNodeList_QueryInterface(list, &IID_IDispatch, NULL);
-        ok( r == E_INVALIDARG || r == E_POINTER, "ret %08x\n", r );
-
         r = IXMLDOMNodeList_get_item(list, 0, NULL);
         ok(r == E_INVALIDARG, "Exected E_INVALIDARG got %08x\n", r);
 
@@ -2738,9 +2735,6 @@ static void test_get_text(void)
         IXMLDOMNode_Release(nodeRoot);
     }
 
-    r = IXMLDOMNodeList_QueryInterface(node_list, &IID_IDispatch, NULL);
-    ok( r == E_INVALIDARG, "ret %08x\n", r );
-
     r = IXMLDOMNodeList_get_length( node_list, NULL );
     ok( r == E_INVALIDARG, "ret %08x\n", r );
 
-- 
1.5.6.5



--------------040200020909080002090806--



More information about the wine-patches mailing list