[PATCH 2/4] d3d9: Remove some useless ERRs (LLVM/Clang).

Henri Verbeet hverbeet at codeweavers.com
Tue Jan 25 12:26:24 CST 2011


These come from the application, so can't be internal errors. Besides, we'd
crash a couple of lines down anyway.
---
 dlls/d3d9/surface.c |    4 ----
 dlls/d3d9/volume.c  |    4 ----
 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/dlls/d3d9/surface.c b/dlls/d3d9/surface.c
index 6601530..4ec6104 100644
--- a/dlls/d3d9/surface.c
+++ b/dlls/d3d9/surface.c
@@ -232,10 +232,6 @@ static HRESULT WINAPI IDirect3DSurface9Impl_GetContainer(LPDIRECT3DSURFACE9 ifac
 
     if (!This->container) return E_NOINTERFACE;
 
-    if (!ppContainer) {
-        ERR("Called without a valid ppContainer\n");
-    }
-
     res = IUnknown_QueryInterface(This->container, riid, ppContainer);
 
     TRACE("Returning ppContainer %p, *ppContainer %p\n", ppContainer, *ppContainer);
diff --git a/dlls/d3d9/volume.c b/dlls/d3d9/volume.c
index 5206187..643238a 100644
--- a/dlls/d3d9/volume.c
+++ b/dlls/d3d9/volume.c
@@ -169,10 +169,6 @@ static HRESULT WINAPI IDirect3DVolume9Impl_GetContainer(LPDIRECT3DVOLUME9 iface,
 
     if (!This->container) return E_NOINTERFACE;
 
-    if (!ppContainer) {
-        ERR("Called without a valid ppContainer.\n");
-    }
-
     res = IUnknown_QueryInterface(This->container, riid, ppContainer);
 
     TRACE("Returning ppContainer %p, *ppContainer %p\n", ppContainer, *ppContainer);
-- 
1.7.3.4




More information about the wine-patches mailing list