[PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity) (try 3)

[Marcus Meissner]

Hi,

We print a FIXME for an out of bounds array access ... but then let
it happily run into it. Just return success instead. CID 5115

(StefanD said return OK is fine. Windows apparently crashes and burns
here, but we want to help the static analyzers not to go crazy here.)

Ciao, Marcus
---
 dlls/wined3d/device.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
index 5bc5a08..30d5b95 100644
--- a/dlls/wined3d/device.c
+++ b/dlls/wined3d/device.c
@@ -1872,12 +1872,13 @@ HRESULT CDECL wined3d_device_multiply_transform(struct wined3d_device *device,
      * below means it will be recorded in a state block change, but it
      * works regardless where it is recorded.
      * If this is found to be wrong, change to StateBlock. */
+    if (state > HIGHEST_TRANSFORMSTATE)
+    {
+        WARN("Unhandled transform state %#x.\n", state);
+        return WINED3D_OK;
+    }
 
-    if (state <= HIGHEST_TRANSFORMSTATE)
-        mat = &device->updateStateBlock->state.transforms[state];
-    else
-        FIXME("Unhandled transform state %#x.\n", state);
-
+    mat = &device->updateStateBlock->state.transforms[state];
     multiply_matrix(&temp, mat, matrix);
 
     /* Apply change via set transform - will reapply to eg. lights this way. */
-- 
1.7.3.4