[PATCH] strmbase: removed superflous NULL check (Coverity)

Marcus Meissner marcus at jet.franken.de
Tue Jun 14 06:00:07 CDT 2011


Hi,

We derefence it some lines up, also HeapFree() can take NULL ptrs.
CID 5058

Ciao, Marcus
---
 dlls/strmbase/outputqueue.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/dlls/strmbase/outputqueue.c b/dlls/strmbase/outputqueue.c
index 200e2da..4f4ecf8 100644
--- a/dlls/strmbase/outputqueue.c
+++ b/dlls/strmbase/outputqueue.c
@@ -130,8 +130,7 @@ HRESULT WINAPI OutputQueue_Destroy(OutputQueue *pOutputQueue)
     DeleteCriticalSection(&pOutputQueue->csQueue);
     CloseHandle(pOutputQueue->hProcessQueue);
 
-    if (pOutputQueue->SampleList)
-        HeapFree(GetProcessHeap(),0,pOutputQueue->SampleList);
+    HeapFree(GetProcessHeap(),0,pOutputQueue->SampleList);
 
     IPin_Release((IPin*)pOutputQueue->pInputPin);
     HeapFree(GetProcessHeap(),0,pOutputQueue);
-- 
1.7.3.4




More information about the wine-patches mailing list